Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Speedup isinstance(3, typing_extensions.SupportsIndex) by >10x #141

Merged
merged 1 commit into from
Apr 13, 2023
Merged

Speedup isinstance(3, typing_extensions.SupportsIndex) by >10x #141

merged 1 commit into from
Apr 13, 2023

Conversation

AlexWaygood
Copy link
Member

On main:

(venv) C:\Users\alexw\coding\typing_extensions>python -m timeit -s "from typing_extensions import SupportsIndex" "isinstance(3, SupportsIndex)"
50000 loops, best of 5: 3.96 usec per loop

With this PR:

(venv) C:\Users\alexw\coding\typing_extensions>python -m timeit -s "from typing_extensions import SupportsIndex" "isinstance(3, SupportsIndex)"
500000 loops, best of 5: 377 nsec per loop

@srittau srittau merged commit 90c866b into python:main Apr 13, 2023
@AlexWaygood AlexWaygood deleted the faster-SupportsIndex branch April 13, 2023 13:32
This was referenced Apr 13, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srittau srittau srittau approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AlexWaygood @srittau