Backport NamedTuple and TypedDict deprecations from Python 3.13 #240
Conversation
| """A simple typed namespace. At runtime it is equivalent to a plain dict. | ||
|
|
||
| TypedDict creates a dictionary type that expects all of its | ||
| TypedDict creates a dictionary type such that a type checker will expect all |
There was a problem hiding this comment.
I took this opportunity to copy-paste the docstring from CPython.
|
Seems like there's some issue with generic namedtuples on 3.12, I'll fix that in a separate PR. |
|
Actually the failure is due to this PR (it's because we now re-implement NamedTuple on 3.12). Fixed it. |
| if __fields is None: | ||
| __fields = kwargs.items() | ||
| def NamedTuple(__typename, __fields=_sentinel, **kwargs): | ||
| """Typed version of namedtuple. |
There was a problem hiding this comment.
If we're adding a docstring the normal way here, we no longer need to monkey-patch it onto the function afterwards:
typing_extensions/src/typing_extensions.py
Line 2726 in f4adac5
If you get rid of the docstring monkey-patching, you'll need to ditch this test, as it'll start to fail:
typing_extensions/src/test_typing_extensions.py
Lines 5098 to 5100 in f9b83a2
There was a problem hiding this comment.
Oh I missed that. I think it's better if we present the same docstring across all versions, so I'll remove the monkey-patching.
| def test_docstring(self): | ||
| self.assertEqual(NamedTuple.__doc__, typing.NamedTuple.__doc__) | ||
| self.assertIsInstance(NamedTuple.__doc__, str) |
There was a problem hiding this comment.
Tbh this test method feels pretty redundant now; I'd just delete the whole method :p
There was a problem hiding this comment.
It still tests that we have some docstring :)
There was a problem hiding this comment.
I'd hope we'd catch it in manual review if somebody proposed deleting the entire docstring in a PR 😄
When I added this test method, my intent was just to test that the monkeypatching in the backport was working correctly. But I guess we can keep it; it doesn't do any harm :)
The PR LGTM!
No description provided.