Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure that ReadOnly is removed when using get_type_hints(include_extra=False) #349

Merged
merged 5 commits into from
Mar 6, 2024
Merged

Make sure that ReadOnly is removed when using get_type_hints(include_extra=False) #349

merged 5 commits into from
Mar 6, 2024

Conversation

sobolevn
Copy link
Member

@sobolevn sobolevn commented Mar 5, 2024

I've noticed that while working on python/cpython#116127

@sobolevn sobolevn mentioned this pull request Mar 5, 2024
Merged
JelleZijlstra
JelleZijlstra reviewed Mar 6, 2024
View reviewed changes
Copy link
Member

@JelleZijlstra JelleZijlstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Could you add a changelog entry and a versionchanged entry in the docs? Something like "When include_extra=False, get_type_hints() now strips :data:ReadOnly from the annotation."

@sobolevn
Copy link
Member Author

sobolevn commented Mar 6, 2024

Done, I assumed that the next version is 4.11.0

@JelleZijlstra JelleZijlstra merged commit c3dc681 into python:main Mar 6, 2024
18 checks passed
@JelleZijlstra
Copy link
Member

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sobolevn @JelleZijlstra