Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't import anything from typing.py in our tests #387

Merged
merged 1 commit into from
May 13, 2024

Conversation

AlexWaygood
Copy link
Member

There's a theoretical footgun here where we could accidentally be testing the typing.py implementation instead of our own implementation/re-export. It doesn't look like there's actually any issues here, but in any event, I think it's good for us to be explicit about when we actually want to use the typing.py version of a symbol by refering to it as typing.$symbol rather than just symbol

@AlexWaygood AlexWaygood merged commit 08c066e into python:main May 13, 2024
18 checks passed
@AlexWaygood AlexWaygood deleted the test-imports branch May 13, 2024 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants