Backport PEP-696 specialisation on Python >=3.11.1 #397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexWaygood
changed the title
AlexWaygood
commented
May 16, 2024
Comment on lines
+6405
to
+6408
| @skipIf( | ||
| sys.version_info < (3, 11, 1), | ||
| "Not yet backported for older versions of Python" | ||
| ) |
There was a problem hiding this comment.
I verified locally that these tests pass with Python 3.11.1 but not with Python 3.11.0...
There was a problem hiding this comment.
It seems like the failures are just that we're missing the defaults from __args__, which doesn't seem too bad. (It may cause problems for introspection but shouldn't usually break creation of types that are normally in annotations.) I'm fine leaving those out for now.
There was a problem hiding this comment.
Yes, the test failures "just" indicate incorrect behaviour rather than crashes
AlexWaygood
changed the title
JelleZijlstra
approved these changes
May 16, 2024
This was referenced May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for #396 on Python 3.11 and Python 3.12. Unfortunately, the
__typing_prepare_subst__hook doesn't exist on Python 3.10 and lower, so I'm not sure it's possible to backport it on older versions of Python without monkeypatchingtyping._GenericAlias.__getitem__, which seems like a bad idea. So maybe we should just document that not all features of PEP-696 are guaranteed to work on Python <=3.10?