Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add TypeExpr #430

Merged
merged 4 commits into from
Jun 22, 2024
Merged

Add TypeExpr #430

merged 4 commits into from
Jun 22, 2024

Conversation

JelleZijlstra
Copy link
Member

Fixes #429. cc @davidfstr

@davidfstr
Copy link
Contributor

Implementation and tests look good.

One capability of TypeExpr that appears to be missing from this implementation is support for the explicit syntax TypeExpr(typx) that just returns typx unchanged. I'm not sure if you wanted to add that capability in this initial PR or in a followup PR.

@JelleZijlstra
Copy link
Member Author

Thanks, I forgot about that; I'll add it in this PR.

@davidfstr
Copy link
Contributor

LGTM

@srittau srittau merged commit e239100 into python:main Jun 22, 2024
21 checks passed
@JelleZijlstra JelleZijlstra deleted the typeexpr branch June 22, 2024 13:57
@JelleZijlstra JelleZijlstra restored the typeexpr branch September 10, 2024 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srittau srittau srittau approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add typing_extensions.TypeExpr
3 participants
@JelleZijlstra @davidfstr @srittau