-
-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Concatenate to support Ellipsis argument #481
Open
Daraan
wants to merge
16
commits into
python:main
Choose a base branch
from
Daraan:concatenate/ellipsis-support-110
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+113
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I am sorry I had to recreate #442. Latest change since then: - if not TYPING_3_11_0:
- with self.assertRaisesRegex(
- TypeError,
- 'each arg must be a type',
- ):
- Concatenate[1, P]
# different location
+ def test_invalid_use(self):
+ # Assure that `_type_check` is called.
+ P = ParamSpec('P')
+ with self.assertRaisesRegex(
+ TypeError,
+ "each arg must be a type",
+ ):
+ Concatenate[(str,), P] |
Daraan
changed the title
Concatenate/ellipsis support 110
Concatenate to support Ellipsis argument
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #110.
This PR adds support for Ellipsis in Concatenate for the Python 3.8-3.10 backports.
Does not fix:
Concatenate
implementation generates runtime exception if parameterized by...
#48 : Using Ellipsis as argument for Callable with a generic.._ConcatenateGenericAlias
Changes:
- Changed _concatenate_getitem to reflect the Python3.11 typing module that allows the Ellipsis parameter.
- For Python 3.10 uses typing._ConcatenateGenericAlias and _concatenate_getitem
- For <=Python 3.9 the typing_extensions._ConcatenateGenericAlias and _concatenate_getitem like before
- For <3.9.2 uses a Dummy class that is temporarily swapped with an Ellipsis input
- added tests and updated tests