Include both license files #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The license keyword is meant for specifying the license string, not the file name of the license. The correct keyword to use for this is license_files. Currently the LICENSE.txt file is being included because license_files defaults to "LICEN[CS]E*", but K5TEST-LICENSE.txt is missing. This change switches to the correct keyword, and additionally includes the K5TEST-LICENSE.txt file. Signed-off-by: Carl George <carl@george.computer>
carlwgeorge
force-pushed
the
license_files
branch
from
af2f4f9
to
3d51034
Compare
jborean93
approved these changes
Sep 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The license keyword is meant for specifying the license string, not the file name of the license. The correct keyword to use for this is license_files. Currently the LICENSE.txt file is being included because license_files defaults to "LICEN[CS]E*", but K5TEST-LICENSE.txt is missing. This change switches to the correct keyword, and additionally includes the K5TEST-LICENSE.txt file.