Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release v0.9.2 #5

Merged
merged 2 commits into from
Nov 28, 2017
Merged

Release v0.9.2 #5

merged 2 commits into from
Nov 28, 2017

Conversation

DirectXMan12
Copy link
Member

Bugfix Release:

  • Handle unreadable directories when searching for the plugin path (Find krb5 path is failed #4)
  • Avoid ResourceWarnings from daemon launches

@DirectXMan12
Avoid ResourceWarnings killing daemons
4dcadde 
Newever versions of Python explicitly warn in tests when
resources like files are left hanging around (they'll be closed
eventually).  We were being warned about our termination of the
krb5 daemons.

Additionally, the call to `wait()` could potentially deadlock if
the daemon wrote too much to stdout or stderr.

These issues are fixed by using switching to actually using the
`Popen#terminate` method (instead of calling `kill` in the pid),
followed by `Popen#communicate` (instead of just `Popen#wait`).
@DirectXMan12
Prepare for v0.9.2 release
ef7c7a7
@DirectXMan12 DirectXMan12 merged commit ced11fa into master Nov 28, 2017
@DirectXMan12 DirectXMan12 deleted the release-stg/v0.9.2 branch November 28, 2017 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frozencemetery frozencemetery frozencemetery approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@DirectXMan12 @frozencemetery