-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support building against mingw headers #147
Comments
Awesome, can you submit a PR with your chances? Some initial feedback based on the linked bug:
Yep, the three header files are already designed to conditionalize logic like that (they currently do it for OSX strangeness). You'd just need to modify setup.py to populate a constant to indicate that we need
There's a method on the However, those constants shouldn't strictly be necessary to compile, and the compilation of that file can be disabled by setting the Lines 195 to 203 in 7018e58
I'd prefer to see if we can detect mingw, but an environment variable is fine for a first pass if you don't have time. |
Here's the pull request for the first part: I'm a little bit nervous about the For the record, here's the build error due to the missing definition for
|
Fix for the pedantic python syntax checkers which didn't like the "bare except" statement: |
I believe this was addressed in #149. |
Building on MSYS2 requires some minor changes, please consider merging them:
gss.h
as the other header files don't exist - this can easily be IFDEFed (I just hacked it)gss_mech_krb5
is not defined in those header files, I used pythonstruct.pack
to generate the valuekrb5-config gssapi
which is not installed - it would error outTo test, just install msys2, then install gss:
pacman -S mingw-w64-x86_64-gss
and then try to buildpython-gssapi
.To see the exact changes that I made to get it to build, please see:
xpra ticket 1691 - comment 7
The text was updated successfully, but these errors were encountered: