Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build on mingw - part 1 #149

Closed
wants to merge 6 commits into from
Closed

build on mingw - part 1 #149

wants to merge 6 commits into from

Conversation

totaam
Copy link
Contributor

@totaam totaam commented Mar 21, 2018

This part should be uncontroversial and does nothing unless:

  • the preprocessor MINGW32 definition is present (header files)
  • detects mingw uisng MINGW_PREFIX the environment variable in setup.py

travis was now failing on Fedora with:
`setup.py:74:1: E722 do not use bare except'`
@DirectXMan12
Copy link
Member

DirectXMan12 commented Mar 21, 2018

looks good to me! Can you squash the 3 use gss.h on mingw commits into one use gss.h on mingw commit, and squash the pedantic checkers don't like bare except back into don't error out? After that, I'll merge. Thanks!

@totaam
Copy link
Contributor Author

totaam commented Mar 21, 2018

Can you squash the 3 use gss.h on mingw commits

Sorry but I have no idea how to squash commits using the github webui, otherwise I would have squashed them already..

@frozencemetery
Copy link
Member

Pushed to master as 2a2b47b.

@DirectXMan12
Copy link
Member

For future reference, just do it via the git CLI (git rebase -i) and then git push --force-with-lease

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants