Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure that arguments that can take None as a value have a default value #29

Closed
DirectXMan12 opened this issue Dec 23, 2014 · 1 comment · Fixed by #35
Closed

Make sure that arguments that can take None as a value have a default value #29

DirectXMan12 opened this issue Dec 23, 2014 · 1 comment · Fixed by #35
Assignees
@frozencemetery
Labels
bug enhancement
Milestone
1.1.0

Comments

@DirectXMan12
Copy link
Member

A couple of methods recently got changed so that they can accept None for certain arguments that were previously marked not None (e.g. acquire_cred). These methods should have those arguments have default values of None so that the methods don't have to be called like acquire_cred(None).
@DirectXMan12 DirectXMan12 added this to the 1.1.0 milestone Dec 23, 2014
@frozencemetery frozencemetery self-assigned this Jan 5, 2015
@DirectXMan12
Copy link
Member Author

Note: this is mostly intended for cases where a call for the form some_func(None) is currently valid

frozencemetery added a commit to frozencemetery/python-gssapi that referenced this issue Jan 5, 2015
@frozencemetery
Default first arg where it can be None and was not previously
de8568b 
The goal here is to change all calls to methods of the form `add_cred(None)`
to `add_cred()` for convenience and clarity.

This closes pythongssapi#29.
@frozencemetery frozencemetery mentioned this issue Jan 5, 2015
Merged
frozencemetery added a commit to frozencemetery/python-gssapi that referenced this issue Jan 5, 2015
@frozencemetery
Default first arg where it can be None and was not previously
305d25b 
The goal here is to change all calls to methods of the form `add_cred(None)`
to `add_cred()` for convenience and clarity.

This closes pythongssapi#29.
frozencemetery added a commit to frozencemetery/python-gssapi that referenced this issue Jan 6, 2015
@frozencemetery
Default first arg where it can be None and was not previously
cfc9f4e 
The goal here is to change all calls to methods of the form `add_cred(None)`
to `add_cred()` for convenience and clarity.

This closes pythongssapi#29.
@frozencemetery frozencemetery mentioned this issue Jan 6, 2015
Closed
frozencemetery added a commit to frozencemetery/python-gssapi that referenced this issue Jan 6, 2015
@frozencemetery
Default first arg where it can be None and was not previously
dec88d0 
The goal here is to change all calls to methods of the form `add_cred(None)`
to `add_cred()` for convenience and clarity.

It has been verified that `acquire_cred_from()` can take nulls.

This closes pythongssapi#29.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@frozencemetery frozencemetery

Labels
bug enhancement
Projects
None yet
Milestone
1.1.0
Development

Successfully merging a pull request may close this issue.

Set several default initial args to None for convenience frozencemetery/python-gssapi
2 participants
@DirectXMan12 @frozencemetery