Fix OID inequality comparison #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DirectXMan12
suggested changes
Jul 25, 2017
gssapi/tests/test_raw.py
Outdated
| krb5_other = gb.OID.from_int_seq(TEST_OIDS['KRB5']['string']) | ||
| spnego = gb.OID.from_int_seq(TEST_OIDS['SPNEGO']['string']) | ||
|
|
||
| a = krb5 == krb5_other |
There was a problem hiding this comment.
make this (krb5 == krb5_other).should_be(True) so that we get nice error messages with should_be
|
Good catch. /me is embarrased |
Due to an extraneous 'or' branch, OID inequality comparison would return the results of an equality comparison. Signed-off-by: Alexander Scheel <ascheel@redhat.com>
cipherboy
force-pushed
the
fix-oid-comparison
branch
from
c7d80a4
to
bc32062
Compare
|
Thank you! Updated :) |
DirectXMan12
approved these changes
Jul 26, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to an extraneous 'or' branch, OID inequality
comparison would return the results of an equality
comparison.