Use collections.abc on Python 3 #154
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tiran
force-pushed
the
collections_abc
branch
2 times, most recently
from
fb19a5e
to
ae173ee
Compare
|
Please add a description to the commit and PR description as to why you're making the change. For example:
Also, the check should be |
|
(follow-up -- is the alias being removed from |
|
The PR addresses https://bugzilla.redhat.com/show_bug.cgi?id=1594834 . The alias will be removed in 3.8. |
|
ok, that's fine. Please add it to the commit message and PR description (and make the other change I mentioned), and I'll merge the PR. |
|
@tiran Hi, do you plan to revise this? |
frozencemetery
force-pushed
the
collections_abc
branch
from
ae173ee
to
f22de51
Compare
frozencemetery
pushed a commit
to tiran/python-gssapi
that referenced
this pull request
Jul 16, 2018
Starting before Python 3.3 (which is the oldest version we support), the ABCs for collections are located at collections.abc, but aliased into collections. Starting in Python 3.7, referring to them using the aliases produces DeprecationWarnings, which breaks our users. The alias will be removed entirely in Python 3.8. Signed-off-by: Christian Heimes <cheimes@redhat.com> [rharwood@redhat.com: Write commit message, update style on checks] Merges: pythongssapi#154
frozencemetery
force-pushed
the
collections_abc
branch
from
02506d2
to
628e5ca
Compare
frozencemetery
pushed a commit
to tiran/python-gssapi
that referenced
this pull request
Jul 16, 2018
Starting before Python 3.3 (which is the oldest version we support), the ABCs for collections are located at collections.abc, but aliased into collections. Starting in Python 3.7, referring to them using the aliases produces DeprecationWarnings, which breaks our users. The alias will be removed entirely in Python 3.8. Signed-off-by: Christian Heimes <cheimes@redhat.com> [rharwood@redhat.com: Write commit message, update style on checks] Merges: pythongssapi#154
Starting before Python 3.3 (which is the oldest version we support), the ABCs for collections are located at collections.abc, but aliased into collections. Starting in Python 3.7, referring to them using the aliases produces DeprecationWarnings, which breaks our users. The alias will be removed entirely in Python 3.8. Signed-off-by: Christian Heimes <cheimes@redhat.com> [rharwood@redhat.com: Write commit message, update style on checks] Merges: pythongssapi#154
frozencemetery
force-pushed
the
collections_abc
branch
from
628e5ca
to
589500a
Compare
frozencemetery
pushed a commit
that referenced
this pull request
Jul 16, 2018
Starting before Python 3.3 (which is the oldest version we support), the ABCs for collections are located at collections.abc, but aliased into collections. Starting in Python 3.7, referring to them using the aliases produces DeprecationWarnings, which breaks our users. The alias will be removed entirely in Python 3.8. Signed-off-by: Christian Heimes <cheimes@redhat.com> [rharwood@redhat.com: Write commit message, update style on checks] Merges: #154
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Christian Heimes cheimes@redhat.com