Fix Loading DLL on Windows Python >=3.8 #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Annnnnd the testing requirements aren't installed on the ones we don't run tests on (－‸ლ) Edit: nope, that's not the issue: decorator isn't in the testing requirements. Something must be pulling it in for the other distros. |
frozencemetery
suggested changes
Apr 3, 2020
|
I figured you would squash the commits like you did for the previous PR so the commit order wouldn't matter. I'll push with new commits in that order. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #193, Python 3.8 no longer searches the PATH for DLLs on Windows and instead looks in standard locations. I've updated the Windows compatibility handling to account for this and use the new
os.add_dll_directory()when possible.I also modified the tests to at least make sure the library can be imported on systems that we can't test on. This would have failed the 3.8 build last release and caught the issue earlier.