Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add python_requires since upstream still supports 3.5 #199

Merged
merged 1 commit into from
Apr 8, 2020
Merged

Add python_requires since upstream still supports 3.5 #199

merged 1 commit into from
Apr 8, 2020

Conversation

frozencemetery
Copy link
Member

Resolves: #198

@jborean93 PTAL

@frozencemetery frozencemetery mentioned this pull request Apr 8, 2020
Closed
@jborean93
Copy link
Contributor

Just wanted to check that when you build the package the setuptools version is at >=24.2.0 as that is what is required for the metadata to be read and generated properly https://packaging.python.org/guides/distributing-packages-using-setuptools/#python-requires.

Also you state that upstream still supports 3.5 but you've used an fstring with 5e91aa0#diff-d7c47bf8b55e340087c202452e7c7a8eR64 which is a Python 3.6 only change. The setup.py contents state 3.6+ as well so I'm just a bit confused by the title here.

@frozencemetery
Copy link
Member Author

Ah, good question. "Upstream" there referred to "upstream python". I'll fix the commit message.

@frozencemetery
Copy link
Member Author

To your other question: we build and upload the packages from fedora:latest (currently 31) so we should be good there, and the Windows builds are done from pip.

@frozencemetery
Add python_requires >= 3.6
d554fce 
The python project still considers 3.5 supported, so we need to ensure
users on 3.5 don't get versions that they can't use.

Resolves: pythongssapi#198
@frozencemetery frozencemetery merged commit d554fce into pythongssapi:master Apr 8, 2020
@jborean93
Copy link
Contributor

Awesome thanks for the clarification here and the quick turnaround. Much appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jborean93 jborean93 jborean93 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

setup.py should have python_requires
2 participants
@frozencemetery @jborean93