Raise exception on unknown usage #203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, we defaulted to conservatively assuming BOTH for usage type when it wasn't obviously INITIATE or ACCEPT. In most simple cases, this will cause invalid values to behave as the user intended. However, it may cause mysterious failures in more complex cases. Err on the side of caution and raise ValueError when we can't determine the intented usage. Resolves: pythongssapi#202
|
wow, that's a lot of duplication, I wonder if a single helper function wouldn't be possible. |
|
It probably is; I'd accept a follow-on patch to make that change. |
|
I agree with @simo5. Happy with the change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we defaulted to conservatively assuming BOTH for usage type
when it wasn't obviously INITIATE or ACCEPT. In most simple cases, this
will cause invalid values to behave as the user intended. However, it
may cause mysterious failures in more complex cases. Err on the side of
caution and raise ValueError when we can't determine the intented usage.
Resolves: #202