changing server_name to server_hostbased_name

[rebeccc]

fixes issue #208

[frozencemetery]

Thanks for the fix.

It seems like it might be better to make server_name have the right value (i.e., rename server_hostbased_name to server_name) and call the current HTTP/sross@ name something else instead. What do you think?

Bit of housekeeping: please make your commit messages conform to https://chris.beams.io/posts/git-commit/ . You may also wish to add this email to your github account so that it gets tracked as your commit.

[rebeccc]

@frozencemetery Changing server_hostbased_name to server_name makes better sense to me, too.

I'm not really sure what to call HTTP/sross@ because I'm not exactly sure what it was trying to show in the tutorial in the first place. I can tell that the tutorial was trying to show the difference between a Name with and without the name_type = gssapi.NameType.hostbased_service, and that they can successfully be compared after canonicalizing them. Should HTTP/sross@ be changed to 'HTTP@' + FQDN?

Edit: Sorry, forgot to respond to the rest of your comment. I'll definitely make sure that the rest of my commits follow that guide, and I'll make sure git is configured next time before committing.

[frozencemetery]

That's a good point. After rereading and thinking about this some more, I think Solly's intent was to show the difference between the NameTypes - the use of "sross" there is accidental leaking of their hostname. So this should work:

>>> import gssapi, socket
>>> FQDN = socket.getfqdn()
>>> 
>>> server_hostbased_name = gssapi.Name(f"HTTP@{FQDN}", name_type=gssapi.NameType.hostbased_service)
>>> server_hostbased_name
Name(b'HTTP@seton.mivehind.net', <OID 1.2.840.113554.1.2.1.4>)
>>> server_name = gssapi.Name(f"HTTP/{FQDN}@")
>>> server_name
Name(b'HTTP/seton.mivehind.net@', None)
>>> 
>>> server_name == server_hostbased_name
False
>>> server_canon_name = server_name.canonicalize(gssapi.MechType.kerberos)
>>> server_hostbased_canon_name = server_hostbased_name.canonicalize(gssapi.MechType.kerberos)
>>> server_canon_name == server_hostbased_canon_name
True
>>> 

So that suggests a better approach, I think.