Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added ok_as_delegate flags #218

Merged
merged 1 commit into from
Jul 14, 2020
Merged

Added ok_as_delegate flags #218

merged 1 commit into from
Jul 14, 2020

Conversation

jborean93
Copy link
Contributor

Adds support for GSS_C_DELEG_POLICY_FLAG and some docs around it. Currently verifying the behaviour on MIT before finalising the commit message and docs.

Fixes #132

@jborean93
Copy link
Contributor Author

Have tested the behaviour of this flag and have documented the results at https://gist.github.com/jborean93/cdc6cef5e7540ade39912ca08020706b. Waiting on some further info before updating the docs #218 (comment).

@jborean93 jborean93 marked this pull request as ready for review July 12, 2020 11:18
@jborean93
Copy link
Contributor Author

@frozencemetery sorry for the false alarm, turns out MIT does act the same as Heimdal I must have done something wrong in my tests. The PR is ready for review.

I ended up calling the RequirementFlag ok_as_delegate as that matches the name in RFC4120 rather than the name of the GSSAPI macro name which is more a software implementation detail.

@jborean93 jborean93 mentioned this pull request Jul 13, 2020
Closed
10 tasks
frozencemetery
frozencemetery approved these changes Jul 14, 2020
View reviewed changes
Copy link
Member

@frozencemetery frozencemetery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll add another commit cleaning up our requirements during merge.

@frozencemetery frozencemetery merged commit 45d4817 into pythongssapi:master Jul 14, 2020
@jborean93 jborean93 deleted the ok_as_delegate branch July 14, 2020 21:23
@jborean93 jborean93 mentioned this pull request Nov 12, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frozencemetery frozencemetery frozencemetery approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for GSS_C_DELEG_POLICY_FLAG
2 participants
@jborean93 @frozencemetery