Fix shlex.split on windows #223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frozencemetery
approved these changes
Aug 26, 2020
There was a problem hiding this comment.
Thanks, this seems good to me, but I'd like to double-check with @aiudirog before merging.
|
I have no problems with this, sounds like a good change. |
aiudirog
approved these changes
Aug 26, 2020
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm trying to compile this package on Windows for
conda-forgeso need to pass in theGSSAPI_LINKER_ARGSandGSSAPI_COMPILER_ARGSenv vars. Unfortunately they're specified using the Windows backslash convention for paths which requires passing theposix=Falseargument toshlex.split