Fix freebsd #232
Merged
Fix freebsd #232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
frozencemetery
commented
Nov 19, 2020
frozencemetery
commented
- Handle GSS_C_DELEG_POLICY_FLAG not being defined by Heimdal in base
- Support Heimdal from ports preferentially to that from base, if available
This value is fortunately specified by RFC 5896. Truly ancient Kerberos implementations, such as the Heimdal in base on FreeBSD at the time of writing, will not provide this flag. However, since unknown flags will be ignored, it's fine to just provide it anyway. Resolves: pythongssapi#228 Signed-off-by: Robbie Harwood <rharwood@redhat.com>
Related: pythongssapi#228 Signed-off-by: Robbie Harwood <rharwood@redhat.com>
Base has heimdal-1.1.0 at the time of writing, while ports have krb5-1.18.2 and heimdal-7.7.0. Related: pythongssapi#228 Signed-off-by: Robbie Harwood <rharwood@redhat.com>
frozencemetery
force-pushed
the
freebsd
branch
from
a1ed5c8
to
a667468
Compare
|
Added a third commit to fix our feature detection by finding the correct library. Ready for review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.