Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure Windows at import time to use the 32-bit kerbeors on a 32-bit python #248

Merged
merged 1 commit into from
May 26, 2021

Conversation

asheshv
Copy link
Contributor

@asheshv asheshv commented May 25, 2021

This change will allow python-gssapi on a 32-bit python application.

Copy link
Member

@frozencemetery frozencemetery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks for your interest in this project. This seems useful, so I do intend to merge support. Couple things first:

  • You'll need to pass CI (doesn't look like anything major is broken).
  • Your commit message subject is too long. I can fix this before merging, but if you'd like to yourself, I suggest reading this post for an idea.

gssapi/_win_config.py Outdated Show resolved Hide resolved
setup.py Outdated Show resolved Hide resolved
@asheshv
Copy link
Contributor Author

asheshv commented May 25, 2021

Hi, thanks for your interest in this project. This seems useful, so I do intend to merge support. Couple things first:

  • You'll need to pass CI (doesn't look like anything major is broken).
    I've checked last CI, something was broken in the last commit.

It have fixed that as well.

  • Your commit message subject is too long. I can fix this before merging, but if you'd like to yourself, I suggest reading this post for an idea.

That will help.

Signed-off-by: Ashesh Vashi <ashesh.vashi@enterprisedb.com>
[rharwood@redhat.com: commit message, squash, minor style tweaks]
@frozencemetery
Copy link
Member

@aiudirog Since we don't have a way to test 32-bit Windows in CI right now, would you mind double-checking this?

@aiudirog
Copy link
Member

This looks good to me, but I think we should add CI support for 32bit, at least on Windows. I think it actually should be fairly easy with a slight modification to the matrix. Give me few moments to try something.

@aiudirog
Copy link
Member

I can't push directly to this branch, so we'll go old school with a patch file.

0001-CI-Build-and-release-on-32bit-Windows-Python.txt


Also, GitHub, why do you not support .patch/.diff files....?

@frozencemetery
Copy link
Member

Thanks, applied it. I think 8 is probably overkill for Windows - let me see if I can pare that down...

@aiudirog
Copy link
Member

Looks like the i386 folder isn't available when kerberos is installed through chocolatey. Maybe we need to find a 32bit specific one?

@frozencemetery
Copy link
Member

Beyond me, sorry. I think adding 32-bit CI isn't a bad idea if it can be made to work. I think you can open a separate PR using the commit here as basis?

@aiudirog
Copy link
Member

That should work, I'll see what I can do.

@aiudirog aiudirog mentioned this pull request May 25, 2021
@frozencemetery frozencemetery merged commit 4f1c2e8 into pythongssapi:main May 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants