Support DCE IOV functions on macOS #258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh and the change https://github.com/pythongssapi/python-gssapi/pull/258/files#diff-60f61ab7a8d1910d86d9fda2261620314edcae5894d5aaa236b821c7256badd7R125 is unrelated but clang will emit warning saying this |
Makes sense. Should be mentioned in the commit description (unless you think it warrants its own commit). |
I'll amend the commit to include this. |
|
Thanks @frozencemetery for the review, I've incorporated the changes and have manually tested again and things work just fine. |
jborean93
force-pushed
the
macOS-IOV
branch
2 times, most recently
from
16411b9
to
7bdffb2
Compare
The DCE IOV functions on macOS are not exported by any public header on the GSS.Framework. While the symbols are considered to be private they haven't changed across any macOS version since the introduction of GSS.Framework. Since the inclusion of ext_dce is still dependent on whether the symbol is present at compile time, their usage in python-gssapi is relatively safe. Provide our own copy of the definitions accordingly. The `-framework GSS.framework` has also been removed from the compiler args as clang emits a warning with these present, and it is only needed for linking. Signed-off-by: Jordan Borean <jborean93@gmail.com> [rharwood@redhat.com: C style, slight comment/commit message tweaks]
frozencemetery
force-pushed
the
macOS-IOV
branch
from
7bdffb2
to
2bccab4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The DCE IOV functions on macOS are not exported by any public header on
the GSS.Framework. This PR defines some macros in the C file that when
compiled against the GSS.Framework will alias the private symbols to the
ones expected by GSSAPI. While the symbols are considered to be private
they haven't changed across any macOS version since the introduction of
GSS.Framework and the inclusion of ext_dce is still dependent on whether
the symbol is present at compile time.
This allows users of this library on macOS to better interop with
Windows SSPI message encryption which typically require the IOV wrapping
functions that were previously unavailable.
This is round 2 from #210 but I'm a lot more happier with this approach as the macros are defined in the
.cfile for the sdist allowing this to work on macOS without requiring a wheel. It is also not relying ondlopen/dlsymat runtime to get the path to the GSS.Framework library which is a big plus.