Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for running tests against Heimdal in CI #262

Merged
merged 1 commit into from
Aug 23, 2021

Conversation

jborean93
Copy link
Contributor

@jborean93 jborean93 commented Aug 11, 2021

This requires pythongssapi/k5test#13 to be reviewed/merged/released first as currently it is installing straight from source to verify the tests do in fact work. Once that is done the lines https://github.com/pythongssapi/python-gssapi/pull/262/files#diff-0466ec3bdb3913aba71d897f97c298a0de3f922e14fe75af374e16e8478104c3R111-R114 can be removed from this PR.

I initially looked at running these tests on Windows as well but it doesn't look like MIT Kerberos on Windows provides a kdc service so I dropped that idea.

Should fix #233 - at least combined with the k5test PR.

Copy link
Member

@frozencemetery frozencemetery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are several "if not heimdal" or "if not darwin" checks - are you intentionally assuming that macOS implies distro heimdal? It's tricky because I think there are three different GSSAPIs one could be using on macOS. I also don't know whether this is worth caring about.

Additional thoughts inline.

ci/run-on-linux.sh Show resolved Hide resolved
gssapi/tests/test_high_level.py Outdated Show resolved Hide resolved
gssapi/tests/test_high_level.py Outdated Show resolved Hide resolved
gssapi/tests/test_high_level.py Outdated Show resolved Hide resolved
gssapi/tests/test_high_level.py Show resolved Hide resolved
gssapi/tests/test_raw.py Outdated Show resolved Hide resolved
gssapi/tests/test_raw.py Outdated Show resolved Hide resolved
gssapi/tests/test_raw.py Outdated Show resolved Hide resolved
gssapi/tests/test_raw.py Outdated Show resolved Hide resolved
gssapi/tests/test_raw.py Outdated Show resolved Hide resolved
@jborean93
Copy link
Contributor Author

are you intentionally assuming that macOS implies distro heimdal?

Somewhat, as you have said someone could have MIT Kerberos, GSS.framework Heimdal, or pure Heimdal installed on macOS so there's no easy way to detect this. I could reuse GSSAPI_KRB5_MAIN_LIB as the check for GSS.framework Heimdal on macOS but at this point it seemed overkill for a very niche scenario. It would also mean that tests will fail on someone who is running with GSS.framework by default as now they would need to set that env var to something that is expected. IMO I think the chances of someone running tests on macOS and they are not using GSS.framework are quite low and not worth considering until someone does encounter it.

Additional thoughts inline.

Thanks, the changes have been made.

Copy link
Member

@frozencemetery frozencemetery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Signed-off-by: Jordan Borean <jborean93@gmail.com>
@frozencemetery frozencemetery merged commit a253964 into pythongssapi:main Aug 23, 2021
@jborean93 jborean93 deleted the heimdal-testing branch August 23, 2021 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support FreeBSD in tests?
2 participants