IOV/AEAD Extensions #47
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This metaclass allows extensions to register new values in any enum by (ab)using metaclasses. For example, this allows for extensions to introduce new RequirementFlags without having to worry about import order.
The GSSAPI DCE Extensions include support for wrapping and unwrapping IOV and AEAD messages (this allows for DCE RPC and other SSPI functionality). Part of #6
The DCE extensions introduced the concept of IOV messages, but there was no way to just get a MIC for those messages. The IOV MIC GSSAPI extension add support for getting MICs for IOV messages. Closes #6
|
Your first commit is a thing of beauty that I am glad you added tests to. This looks good once Travis passes. |
|
Merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces IOV/AEAD extensions (closing #6). There are two parts: the original DCE extensions, as well as the IOV MIC extensions introduced later.
Additionally, a method which allows extensions to add additional elements to Enums without worrying about import order is included.