Don't inquire about incomplete security contexts #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit changes `SecurityContext` to handle a couple of cases where we called `_inquire` when the context was not fully established. A bug in MIT krb5 prevents this from working properly. In the case of `complete`, we simply cache the result of the last `step` call. Fixes #69
|
Any chance you could specify what versions of MIT are affected (e.g., "MIT Kerberos up to version X.YY is affected...")? When the fix is landed in MIT, we'll probably want to note it as well. |
I figured I'd do that there's a version in which it does work |
|
Open pull request: krb5/krb5#285 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit changes
SecurityContextto handle a couple of cases wherewe called
_inquirewhen the context was not fully established. A bugin MIT krb5 prevents this from working properly.
In the case of
complete, we simply cache the result of the laststepcall.Fixes #69