Fix Delegated Credentials Issues #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, in the high-level API, we would unconditionally set wrap the return value of delegated_creds, which could result in delegated_creds being set to the default credentials when no delegated creds were returned (since the call would be `Credentials(None)`). This changes the logic so that delegated_creds stays set as `None` unless delegated_creds are actually returned. Partial solution for #96
This commit exposes `SecurityContext#delegated_creds` as a documented property. Previously, it existed as a field, but was undocumented. Fixes #95
|
Okay by me to merge once it's past travis. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a fix for #95 (exposing
delegated_credsas a property).It also contains a partial fix for #96 (setting
delegated_credstoNoneif no delegated credentials are returned by the low-level API, and only wrapping the result in a high-levelCredentialsAPI if delegated credentials are actually returned), which should have while we debate a longer-term solution.