Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warn rather than raise on opportunistic auth failure. #31

Merged
merged 1 commit into from
Mar 2, 2021
Merged

Warn rather than raise on opportunistic auth failure. #31

merged 1 commit into from
Mar 2, 2021

Commits on Feb 25, 2021

  1. Warn instead of raising on opportunistic auth failure 

    If the request results in a 401, this reduces to the non-opportunistic
case, whose behavior remains the same as before.

This allows callers for whom enabling opportunistic auth is a more
appropriate default to do so, without needing to write additional
exception handling code to ensure they recover in the case that
opportunistic auth failed.  In other words, take "opportunistic" to mean
"try early, but if that fails, don't just give up right away".

Signed-off-by: Joshua Bronson <jab@twosigma.com>
[rharwood@redhat.com: restore debug message, fussy style things]
    @twosigmajab @frozencemetery
    twosigmajab authored and frozencemetery committed Feb 25, 2021
    Configuration menu
    Copy the full SHA
    e56466f View commit details
    Browse the repository at this point in the history