Explicit Principal code sample is wrong (#33) #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@frozencemetery Please have a look. |
|
@michael-o, you need to rewrite your commit comment to add your signature, DCO required in this repo. |
michael-o
force-pushed
the
fix-explicit-principal-example
branch
from
d531802
to
78910e0
Compare
|
@simo5 Done. Is that sufficient? |
|
The bot is happy :-) |
Closes: pythongssapi#33 Signed-off-by: Michael Osipov <michael.osipov@siemens.com> [rharwood@redhat.com: commit message styling]
frozencemetery
force-pushed
the
fix-explicit-principal-example
branch
from
78910e0
to
81ba52a
Compare
frozencemetery
approved these changes
Apr 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #33