Drop out of sequence detection (#38) #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michael-o
force-pushed
the
drop-out-of-sequence-detection
branch
2 times, most recently
from
5aa04ff
to
f40385e
Compare
|
Is it possible to add this change to https://github.com/pythongssapi/requests-gssapi/blob/main/HISTORY.rst. The use of out of sequence is mostly just because requests-kerberos (which this is a port of) requested this and the latter exposed a way to wrap messages for subsequent HTTP payloads for specific use cases. But you are right, having it here does not make sense. |
SPNEGO over HTTP does not use any message wrapping, therefore requesting out of sequence detection doesn't make sense. This fixes pythongssapi#38 Signed-off-by: Michael Osipov <michael.osipov@siemens.com>
michael-o
force-pushed
the
drop-out-of-sequence-detection
branch
from
f40385e
to
a9909c9
Compare
|
@jborean93 Done, have a look. |
jborean93
approved these changes
Jan 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SPNEGO over HTTP does not use any message wrapping, therefore requesting
out of sequence detection doesn't make sense.
This fixes #38