Suggestion for fixing the propblem with type comparisons in QSettingsManager._get #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
June 11, 2015 13:25
For some reason if I use the <code>saveState()</code> function of a <code>QMainWindow</code> object comparing the <code>QByteArray</code> with None returns true and prevents the <code>set()</code> function from updating the settings value. So I added an explicit condition for None.
mfitzp
added a commit
that referenced
this pull request
Jul 26, 2015
Suggestion for fixing the propblem with type comparisons in QSettingsManager._get
|
Thanks again for your contributions @MrLeeH I have a few tests to run and then I'll release this onto PyPi. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.