This repository has been archived by the owner on Aug 7, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: cleaning up the readme to reflect latest changes Test Plan: n/a Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
vkuzo
added a commit
that referenced
this pull request
Jul 16, 2024
Summary: cleaning up the readme to reflect latest changes Test Plan: n/a Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: da7d54136aee94c59806fa68eda012ef957f05c6 Pull Request resolved: #317
facebook-github-bot
added
the
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
label
Jul 16, 2024
Summary: cleaning up the readme to reflect latest changes Test Plan: n/a Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
vkuzo
added a commit
that referenced
this pull request
Jul 16, 2024
Summary: cleaning up the readme to reflect latest changes Test Plan: n/a Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: 74e69d306600a1d9e5c208fcf77ac34563ec9f3a Pull Request resolved: #317
drisspg
reviewed
Jul 16, 2024
@@ -113,30 +114,32 @@ for _ in range(N_ITER): | |||
optimizer.step() | |||
``` | |||
|
|||
# 🧭 Code Organization | |||
# Multi GPU User API |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we could say something like we support torch's FSDP for data parallelsim compose with Dtensors' TP API
drisspg
approved these changes
Jul 16, 2024
Summary: cleaning up the readme to reflect latest changes Test Plan: n/a Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
vkuzo
added a commit
that referenced
this pull request
Jul 16, 2024
Summary: cleaning up the readme to reflect latest changes Test Plan: n/a Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: a44aaa4001020109c472f117b3931e2bbae0440d Pull Request resolved: #317
@vkuzo has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
This pull request has been merged in 38c02fe. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Summary:
cleaning up the readme to reflect latest changes
Test Plan:
n/a
Reviewers:
Subscribers:
Tasks:
Tags:
Differential Revision: D59827460