Fix deprecated symbol loading in zipped deployments #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
torchfix currentyl uses standard filesystem methods to find and load the deprecated symbols data from disk. When running flake8 as zipped deployments, this fails because the data is not accessible as a standard filesystem path. This replaces the filesystem usage with stdlib `pkgutil.get_data()` [1] that is capable of resolving the data file within the zip deployment, and loading that data using the correct internal mechanisms. 1: https://docs.python.org/3/library/pkgutil.html#pkgutil.get_data
facebook-github-bot
added
the
CLA Signed
|
Prototyped and tested internally as D56278503. |
|
Great, thanks! |
kit1980
approved these changes
Apr 17, 2024
kit1980
approved these changes
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
torchfix currentyl uses standard filesystem methods to find and load the
deprecated symbols data from disk. When running flake8 as zipped
deployments, this fails because the data is not accessible as a standard
filesystem path.
This replaces the filesystem usage with stdlib
pkgutil.get_data()[1]that is capable of resolving the data file within the zip deployment,
and loading that data using the correct internal mechanisms.
1: https://docs.python.org/3/library/pkgutil.html#pkgutil.get_data