Skip to content

Commit

Permalink
Remove CPU support for partial_rowwise_adam (#1773)
Browse files Browse the repository at this point in the history
Summary:
Pull Request resolved: #1773

This diff is a part of FBGEMM TBE optimizer deprecation plan (see
#1727)

Changes include:
- Setting `has_cpu_support` of `partial_rowwise_adam` to
  `False` in the code gen script
- Updating `codegen/TARGETS` and `CMakeLists.txt`

See D45835048 for how the changes affect the code generation

Reviewed By: csmiler

Differential Revision: D45845400

fbshipit-source-id: 0a41c1b83b512a03e42d433d007c6f15a1eaaeb3
  • Loading branch information
q10 authored and facebook-github-bot committed Jun 2, 2023
1 parent 323afc5 commit d153feb
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion fbgemm_gpu/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -168,7 +168,6 @@ file(GLOB_RECURSE asmjit_sources

set(COMMON_OPTIMIZERS
adagrad
partial_rowwise_adam
partial_rowwise_lamb
rowwise_adagrad
rowwise_adagrad_with_counter
Expand All @@ -181,6 +180,7 @@ set(CPU_ONLY_OPTIMIZERS "")
set(GPU_ONLY_OPTIMIZERS
adam
lamb
partial_rowwise_adam
lars_sgd
rowwise_adagrad_with_weight_decay
approx_rowwise_adagrad_with_weight_decay)
Expand Down
2 changes: 1 addition & 1 deletion fbgemm_gpu/codegen/embedding_backward_code_generator.py
Original file line number Diff line number Diff line change
Expand Up @@ -1337,7 +1337,7 @@ def partial_rowwise_adam() -> None:
split_weight_update=split_weight_update,
split_post_update="",
split_weight_update_cpu=split_weight_update_cpu,
has_cpu_support=True,
has_cpu_support=False,
has_gpu_support=True,
has_vbe_support=False,
)
Expand Down

0 comments on commit d153feb

Please sign in to comment.