[CI] Run NVIDIA GPU tests on A10 per PR #1544
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for pytorch-fbgemm-docs canceled.
|
shintaro-iwasaki
force-pushed
the
siwasaki/pr/test_nvidia_gpu
branch
from
b738817 to
a24d745
Compare
|
@shintaro-iwasaki has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
shintaro-iwasaki
force-pushed
the
siwasaki/pr/test_nvidia_gpu
branch
from
a24d745 to
d642bde
Compare
|
@shintaro-iwasaki has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
shintaro-iwasaki
force-pushed
the
siwasaki/pr/test_nvidia_gpu
branch
from
d642bde to
e6a0e50
Compare
|
@shintaro-iwasaki has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
shintaro-iwasaki
force-pushed
the
siwasaki/pr/test_nvidia_gpu
branch
from
e6a0e50 to
c5bec2b
Compare
|
@shintaro-iwasaki has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@shintaro-iwasaki merged this pull request in 3848313. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The OSS side does not run any NVIDIA-GPU unit test, so we cannot catch any OSS-specific issues before merging it; we run these NVIDIA-GPU tests only when a nightly build is pushed to PyPI. This sometimes breaks our nightly build; our customers get unhappy.
Solution
This PR adds a new GitHub Action job that runs unit tests on an AWS NVIDIA A10 machine "per PR". This job creates a wheel file and tests it as the nightly job does, so it should be able to detect some wheel-related issues too (e.g., a build procedure was updated but the nightly script is not updated) though it is not comprehensive (see below).
Note:
test_wheel_nightly) to your PR, which runs the real wheel-creation scripts withupload_pypidisabled.