Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove CPU support for partial_rowwise_adam #1773

Closed
wants to merge 1 commit into from
Closed

Remove CPU support for partial_rowwise_adam #1773

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion fbgemm_gpu/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,7 +168,6 @@ file(GLOB_RECURSE asmjit_sources

set(COMMON_OPTIMIZERS
adagrad
partial_rowwise_adam
partial_rowwise_lamb
rowwise_adagrad
rowwise_adagrad_with_counter
Expand All @@ -181,6 +180,7 @@ set(CPU_ONLY_OPTIMIZERS "")
set(GPU_ONLY_OPTIMIZERS
adam
lamb
partial_rowwise_adam
lars_sgd
rowwise_adagrad_with_weight_decay
approx_rowwise_adagrad_with_weight_decay)
Expand Down
2 changes: 1 addition & 1 deletion fbgemm_gpu/codegen/embedding_backward_code_generator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1337,7 +1337,7 @@ def partial_rowwise_adam() -> None:
split_weight_update=split_weight_update,
split_post_update="",
split_weight_update_cpu=split_weight_update_cpu,
has_cpu_support=True,
has_cpu_support=False,
has_gpu_support=True,
has_vbe_support=False,
)
Expand Down