Fix torchscript issue #2078
Closed
Fix torchscript issue #2078
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for pytorch-fbgemm-docs canceled.
|
|
This pull request was exported from Phabricator. Differential Revision: D50474951 |
Summary: Check https://fb.workplace.com/groups/957614988799577/permalink/995501075010968/ Similar to D29056288 . Didn't know `split_embedding_weights_with_scale_bias` is used in forward path in torchscript? Reviewed By: q10, mengyingdu Differential Revision: D50474951
jianyuh
force-pushed
the
export-D50474951
branch
from
dbdf780 to
2b030ab
Compare
|
This pull request was exported from Phabricator. Differential Revision: D50474951 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D50474951 |
|
This pull request has been merged in e93fb0c. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Check https://fb.workplace.com/groups/957614988799577/permalink/995501075010968/
Similar to D29056288 .
Didn't know
split_embedding_weights_with_scale_biasis used in forward path in torchscript?Reviewed By: q10, mengyingdu
Differential Revision: D50474951