updates for ROCm 6.0 support (#2086) #2088
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No ciflow labels are configured for this repo. |
✅ Deploy Preview for pytorch-fbgemm-docs canceled.
|
|
This pull request was exported from Phabricator. Differential Revision: D50580075 |
q10
pushed a commit
to q10/FBGEMM
that referenced
this pull request
Oct 24, 2023
Summary: ROCm 6.0 introduces backwards-incompatible changes such as removing the long-deprecated use of `__HIP_PLATFORM_HCC__`. It is better to use the USE_ROCM macro which is already defined and indicates a ROCm build. This PR also defines `__HIP_PLATFORM_AMD__` which is the new symbol name. This symbol is still required for compiling with HIP headers but when not using hip-clang. Reviewed By: sryap Differential Revision: D50580075 Pulled By: sryap
|
This pull request was exported from Phabricator. Differential Revision: D50580075 |
Summary: ROCm 6.0 introduces backwards-incompatible changes such as removing the long-deprecated use of `__HIP_PLATFORM_HCC__`. It is better to use the USE_ROCM macro which is already defined and indicates a ROCm build. This PR also defines `__HIP_PLATFORM_AMD__` which is the new symbol name. This symbol is still required for compiling with HIP headers but when not using hip-clang. Reviewed By: sryap Differential Revision: D50580075 Pulled By: sryap
|
This pull request was exported from Phabricator. Differential Revision: D50580075 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D50580075 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
ROCm 6.0 introduces backwards-incompatible changes such as removing the long-deprecated use of
__HIP_PLATFORM_HCC__. It is better to use the USE_ROCM macro which is already defined and indicates a ROCm build. This PR also defines__HIP_PLATFORM_AMD__which is the new symbol name. This symbol is still required for compiling with HIP headers but when not using hip-clang.Differential Revision: D50580075
Pulled By: q10