New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add abstract impl fbgemm::dense_to_jagged #2193

Closed

xuzhao9 wants to merge 1 commit into pytorch:main from xuzhao9:export-D51216256

Contributor

xuzhao9 commented Dec 6, 2023

Summary:

Remove the meta cpp function fbgemm::dense_to_jagged() and fbgemm::dense_to_jagged_forward()
Replace it with the Python abstract impl dense_to_jagged()

Reviewed By: yanboliang

Differential Revision: D51216256

netlify bot commented Dec 6, 2023 •

edited

Loading

✅ Deploy Preview for pytorch-fbgemm-docs canceled.

Name	Link
🔨 Latest commit	`b468064`
🔍 Latest deploy log	https://app.netlify.com/sites/pytorch-fbgemm-docs/deploys/6571f678f456d10008715f0a

facebook-github-bot added the cla signed label

Contributor

facebook-github-bot commented Dec 6, 2023

This pull request was exported from Phabricator. Differential Revision: D51216256

facebook-github-bot added the fb-exported label

xuzhao9 added a commit to xuzhao9/FBGEMM that referenced this pull request


          Add abstract impl fbgemm::dense_to_jagged (pytorch#2193)

3aa467d

Summary:

1. Remove the meta cpp function fbgemm::dense_to_jagged() and fbgemm::dense_to_jagged_forward()
2. Replace it with the Python abstract impl dense_to_jagged()

Reviewed By: yanboliang

Differential Revision: D51216256

xuzhao9 force-pushed the export-D51216256 branch from c79028d to 3aa467d Compare

December 6, 2023 23:59

Contributor

facebook-github-bot commented Dec 6, 2023

This pull request was exported from Phabricator. Differential Revision: D51216256

xuzhao9 added a commit to xuzhao9/FBGEMM that referenced this pull request


          Add abstract impl fbgemm::dense_to_jagged (pytorch#2193)

286bbe0

Summary:

1. Remove the meta cpp function fbgemm::dense_to_jagged() and fbgemm::dense_to_jagged_forward()
2. Replace it with the Python abstract impl dense_to_jagged()

Reviewed By: yanboliang

Differential Revision: D51216256

xuzhao9 force-pushed the export-D51216256 branch from 3aa467d to 286bbe0 Compare

December 6, 2023 23:59

Contributor

facebook-github-bot commented Dec 7, 2023

This pull request was exported from Phabricator. Differential Revision: D51216256

xuzhao9 added a commit to xuzhao9/FBGEMM that referenced this pull request


          Add abstract impl fbgemm::dense_to_jagged (pytorch#2193)

51adef6

Summary:

1. Remove the meta cpp function fbgemm::dense_to_jagged() and fbgemm::dense_to_jagged_forward()
2. Replace it with the Python abstract impl dense_to_jagged()

Reviewed By: yanboliang

Differential Revision: D51216256

xuzhao9 force-pushed the export-D51216256 branch from 286bbe0 to 51adef6 Compare

December 7, 2023 00:00

Contributor

facebook-github-bot commented Dec 7, 2023

This pull request was exported from Phabricator. Differential Revision: D51216256

xuzhao9 added a commit to xuzhao9/FBGEMM that referenced this pull request


          Add abstract impl fbgemm::dense_to_jagged (pytorch#2193)

fb648a5

Summary:

1. Remove the meta cpp function fbgemm::dense_to_jagged() and fbgemm::dense_to_jagged_forward()
2. Replace it with the Python abstract impl dense_to_jagged()

Reviewed By: yanboliang

Differential Revision: D51216256

xuzhao9 force-pushed the export-D51216256 branch from 51adef6 to fb648a5 Compare

December 7, 2023 00:04

Contributor

facebook-github-bot commented Dec 7, 2023

This pull request was exported from Phabricator. Differential Revision: D51216256

xuzhao9 added a commit to xuzhao9/FBGEMM that referenced this pull request


          Add abstract impl fbgemm::dense_to_jagged (pytorch#2193)

e65e4ce

Summary:

1. Remove the meta cpp function fbgemm::dense_to_jagged() and fbgemm::dense_to_jagged_forward()
2. Replace it with the Python abstract impl dense_to_jagged()

Reviewed By: yanboliang

Differential Revision: D51216256

xuzhao9 force-pushed the export-D51216256 branch from fb648a5 to e65e4ce Compare

December 7, 2023 00:05

Contributor

facebook-github-bot commented Dec 7, 2023

This pull request was exported from Phabricator. Differential Revision: D51216256

xuzhao9 added a commit to xuzhao9/FBGEMM that referenced this pull request


          Add abstract impl fbgemm::dense_to_jagged (pytorch#2193)

94fa0c2

Summary:

1. Remove the meta cpp function fbgemm::dense_to_jagged() and fbgemm::dense_to_jagged_forward()
2. Replace it with the Python abstract impl dense_to_jagged()

Reviewed By: yanboliang

Differential Revision: D51216256

xuzhao9 force-pushed the export-D51216256 branch from e65e4ce to 94fa0c2 Compare

December 7, 2023 00:06

Contributor

facebook-github-bot commented Dec 7, 2023

This pull request was exported from Phabricator. Differential Revision: D51216256

1 similar comment

Contributor

facebook-github-bot commented Dec 7, 2023

This pull request was exported from Phabricator. Differential Revision: D51216256

xuzhao9 added a commit to xuzhao9/FBGEMM that referenced this pull request


          Add abstract impl fbgemm::dense_to_jagged (pytorch#2193)

86a2314

Summary:
Pull Request resolved: pytorch#2193

1. Remove the meta cpp function fbgemm::dense_to_jagged() and fbgemm::dense_to_jagged_forward()
2. Replace it with the Python abstract impl dense_to_jagged()

Reviewed By: yanboliang

Differential Revision: D51216256

fbshipit-source-id: a62f6b4448259e90378a0bd055820ba627462414

xuzhao9 force-pushed the export-D51216256 branch from 94fa0c2 to 86a2314 Compare

December 7, 2023 15:44

Contributor

facebook-github-bot commented Dec 7, 2023

This pull request was exported from Phabricator. Differential Revision: D51216256

xuzhao9 added a commit to xuzhao9/FBGEMM that referenced this pull request


          Add abstract impl fbgemm::dense_to_jagged (pytorch#2193)

e276fb9

Summary:
Pull Request resolved: pytorch#2193

1. Remove the meta cpp function fbgemm::dense_to_jagged() and fbgemm::dense_to_jagged_forward()
2. Replace it with the Python abstract impl dense_to_jagged()

Reviewed By: yanboliang

Differential Revision: D51216256

fbshipit-source-id: d6e3026044fdbbf5e9a9a8e49dbb6dc28ba6982e

xuzhao9 force-pushed the export-D51216256 branch from 86a2314 to e276fb9 Compare

December 7, 2023 15:51

Contributor

facebook-github-bot commented Dec 7, 2023

This pull request was exported from Phabricator. Differential Revision: D51216256

xuzhao9 added a commit to xuzhao9/FBGEMM that referenced this pull request


          Add abstract impl fbgemm::dense_to_jagged (pytorch#2193)

5db997f

Summary:
Pull Request resolved: pytorch#2193

1. Remove the meta cpp function fbgemm::dense_to_jagged() and fbgemm::dense_to_jagged_forward()
2. Replace it with the Python abstract impl dense_to_jagged()

Reviewed By: yanboliang

Differential Revision: D51216256

fbshipit-source-id: 94a130cd118bbbce54fc90ce4527a7f3823839e2

xuzhao9 force-pushed the export-D51216256 branch from e276fb9 to 5db997f Compare

December 7, 2023 16:29

Contributor

facebook-github-bot commented Dec 7, 2023

This pull request was exported from Phabricator. Differential Revision: D51216256

xuzhao9 added a commit to xuzhao9/FBGEMM that referenced this pull request


          Add abstract impl fbgemm::dense_to_jagged (pytorch#2193)

a7d47d4

Summary:
Pull Request resolved: pytorch#2193

1. Remove the meta cpp function fbgemm::dense_to_jagged() and fbgemm::dense_to_jagged_forward()
2. Replace it with the Python abstract impl dense_to_jagged()

Reviewed By: zou3519, yanboliang

Differential Revision: D51216256

fbshipit-source-id: 3cdb21b75b00d372054c8d23e84e6fb800f9a863

xuzhao9 force-pushed the export-D51216256 branch from 5db997f to a7d47d4 Compare

December 7, 2023 16:37


          Add abstract impl fbgemm::dense_to_jagged (pytorch#2193)

b468064

Summary:
Pull Request resolved: pytorch#2193

1. Remove the meta cpp function fbgemm::dense_to_jagged() and fbgemm::dense_to_jagged_forward()
2. Replace it with the Python abstract impl dense_to_jagged()

Reviewed By: zou3519, yanboliang

Differential Revision: D51216256

fbshipit-source-id: db6cc16d2eb91cff21ab1c4eb512af69338c1826

Contributor

facebook-github-bot commented Dec 7, 2023

This pull request was exported from Phabricator. Differential Revision: D51216256

xuzhao9 force-pushed the export-D51216256 branch from a7d47d4 to b468064 Compare

December 7, 2023 16:44

facebook-github-bot closed this in

f8def44

facebook-github-bot added the Merged label

Contributor

facebook-github-bot commented Dec 7, 2023

This pull request has been merged in f8def44.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla signed fb-exported Merged