Optimize the cache fetch for forward split, pt. 2B #2282
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for pytorch-fbgemm-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
This pull request was exported from Phabricator. Differential Revision: D53033916 |
q10
added a commit
to q10/FBGEMM
that referenced
this pull request
Jan 24, 2024
Summary: This follows up the work on D51865590 and D52679387 by plumbing the `uvm_cache_stats` argument passing up to the Python API level. `local_uvm_cache_stats` is now zeroed out before the prefetch step as opposed to after, to allow for the data to be passed into the forward step. This is a re-attempt of landing D51995949 with additions copied from D52670550 Differential Revision: D53033916
|
This pull request was exported from Phabricator. Differential Revision: D53033916 |
q10
added a commit
to q10/FBGEMM
that referenced
this pull request
Jan 24, 2024
Summary: This follows up the work on D51865590 and D52679387 by plumbing the `uvm_cache_stats` argument passing up to the Python API level. `local_uvm_cache_stats` is now zeroed out before the prefetch step as opposed to after, to allow for the data to be passed into the forward step. This is a re-attempt of landing D51995949 with additions copied from D52670550 Differential Revision: D53033916
|
This pull request was exported from Phabricator. Differential Revision: D53033916 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D53033916 |
q10
added a commit
to q10/FBGEMM
that referenced
this pull request
Feb 1, 2024
Summary: This follows up the work on D51865590 and D52679387 by plumbing the `uvm_cache_stats` argument passing up to the Python API level. `local_uvm_cache_stats` is now zeroed out before the prefetch step as opposed to after, to allow for the data to be passed into the forward step. This is a re-attempt of landing D51995949 with additions copied from D52670550 Differential Revision: D53033916
|
This pull request was exported from Phabricator. Differential Revision: D53033916 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D53033916 |
q10
added a commit
to q10/FBGEMM
that referenced
this pull request
Feb 1, 2024
Summary: This follows up the work on D51865590 and D52679387 by plumbing the `uvm_cache_stats` argument passing up to the Python API level. `local_uvm_cache_stats` is now zeroed out before the prefetch step as opposed to after, to allow for the data to be passed into the forward step. This is a re-attempt of landing D51995949 with additions copied from D52670550 Differential Revision: D53033916
|
This pull request was exported from Phabricator. Differential Revision: D53033916 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D53033916 |
q10
added a commit
to q10/FBGEMM
that referenced
this pull request
Feb 1, 2024
Summary: Pull Request resolved: pytorch#2282 This follows up the work on D51865590 and D52679387 by plumbing the `uvm_cache_stats` argument passing up to the Python API level. `local_uvm_cache_stats` is now zeroed out before the prefetch step as opposed to after, to allow for the data to be passed into the forward step. This is a re-attempt of landing D51995949 with additions copied from D52670550 Differential Revision: D53033916 fbshipit-source-id: 3611011ac93198d1b7a4b479f3af3322eb19e0f2
q10
added a commit
to q10/FBGEMM
that referenced
this pull request
Feb 5, 2024
Summary: This follows up the work on D51865590 and D52679387 by plumbing the `uvm_cache_stats` argument passing up to the Python API level. `local_uvm_cache_stats` is now zeroed out before the prefetch step as opposed to after, to allow for the data to be passed into the forward step. This is a re-attempt of landing D51995949 with additions copied from D52670550 Differential Revision: D53033916
|
This pull request was exported from Phabricator. Differential Revision: D53033916 |
q10
added a commit
to q10/FBGEMM
that referenced
this pull request
Feb 5, 2024
Summary: This follows up the work on D51865590 and D52679387 by plumbing the `uvm_cache_stats` argument passing up to the Python API level. `local_uvm_cache_stats` is now zeroed out before the prefetch step as opposed to after, to allow for the data to be passed into the forward step. This is a re-attempt of landing D51995949 with additions copied from D52670550 Differential Revision: D53033916
|
This pull request was exported from Phabricator. Differential Revision: D53033916 |
q10
added a commit
to q10/FBGEMM
that referenced
this pull request
Feb 5, 2024
Summary: This follows up the work on D51865590 and D52679387 by plumbing the `uvm_cache_stats` argument passing up to the Python API level. `local_uvm_cache_stats` is now zeroed out before the prefetch step as opposed to after, to allow for the data to be passed into the forward step. This is a re-attempt of landing D51995949 with additions copied from D52670550 Differential Revision: D53033916
|
This pull request was exported from Phabricator. Differential Revision: D53033916 |
q10
added a commit
to q10/FBGEMM
that referenced
this pull request
Feb 6, 2024
Summary: This follows up the work on D51865590 and D52679387 by plumbing the `uvm_cache_stats` argument passing up to the Python API level. `local_uvm_cache_stats` is now zeroed out before the prefetch step as opposed to after, to allow for the data to be passed into the forward step. This is a re-attempt of landing D51995949 with additions copied from D52670550 Reviewed By: spcyppt Differential Revision: D53033916
|
This pull request was exported from Phabricator. Differential Revision: D53033916 |
Summary: This follows up the work on D51865590 and D52679387 by plumbing the `uvm_cache_stats` argument passing up to the Python API level. `local_uvm_cache_stats` is now zeroed out before the prefetch step as opposed to after, to allow for the data to be passed into the forward step. This is a re-attempt of landing D51995949 with additions copied from D52670550 Reviewed By: spcyppt Differential Revision: D53033916
|
This pull request was exported from Phabricator. Differential Revision: D53033916 |
|
This pull request has been merged in c8cb1a2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This follows up the work on D51865590 and D52679387 by plumbing the
uvm_cache_statsargument passing up to the Python API level.local_uvm_cache_statsis now zeroed out before the prefetch step as opposed to after, to allow for the data to be passed into the forward step.This is a re-attempt of landing D51995949 with additions copied from D52670550
Differential Revision: D53033916