Use release branch of Nova workflow #2489
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D55947486 |
✅ Deploy Preview for pytorch-fbgemm-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
spcyppt
force-pushed
the
export-D55947486
branch
from
78eb647 to
ab1cdff
Compare
|
This pull request was exported from Phabricator. Differential Revision: D55947486 |
spcyppt
added a commit
to spcyppt/FBGEMM
that referenced
this pull request
Apr 10, 2024
Summary: Changes in Nova framwork does not work with our current script. pytorch/test-infra#5071 (comment) Switch to use release branch of Nova workflow to guarantee that the workflow is stable throughout the release cycle. Differential Revision: D55947486
spcyppt
force-pushed
the
export-D55947486
branch
from
ab1cdff to
07be7b0
Compare
|
This pull request was exported from Phabricator. Differential Revision: D55947486 |
Summary: Changes in Nova framwork does not work with our current script. pytorch/test-infra#5071 (comment) Switch to use release branch of Nova workflow to guarantee that the workflow is stable throughout the release cycle. Differential Revision: D55947486
spcyppt
force-pushed
the
export-D55947486
branch
from
07be7b0 to
011b7e3
Compare
|
This pull request was exported from Phabricator. Differential Revision: D55947486 |
huydhn
approved these changes
Apr 10, 2024
|
Wait a sec, I thought this is going to fbgemm release branch. For the main branch, I think it's better to use the test-infra @main instead. And yes, we will add the option to fallback to |
|
@huydhn It's also currently blocking our nightly releases, so I'm changing this in FBGEMM main to unblock nightly release. Once the fallback is added and merged, I will change back to use test-infra@main in main. Or should I wait? |
|
This pull request has been merged in 2884409. |
spcyppt
added a commit
that referenced
this pull request
Apr 10, 2024
Summary: Changes in Nova framwork does not work with our current script. pytorch/test-infra#5071 (comment) Switch to use release branch of Nova workflow to guarantee that the workflow is stable throughout the release cycle. Pull Request resolved: #2489 Reviewed By: q10, huydhn Differential Revision: D55947486 fbshipit-source-id: e12552776bccb443cd1983fc037e8c08715c0749
spcyppt
added a commit
to spcyppt/FBGEMM
that referenced
this pull request
Apr 10, 2024
Summary: [Fallback option](pytorch/test-infra@751efc1) is added and merge for Nova @ main branch. We can safely revert D55947486 to use main branch. D55947486 was to mainly unblock nightly releases and to be used for OSS release cycle. Note that the change of [switching to Nova release branch](pytorch#2489 (comment)) had already been cherrypicked into release branch (v0.7.0-release) Differential Revision: D55993279
spcyppt
added a commit
to spcyppt/FBGEMM
that referenced
this pull request
Apr 11, 2024
Summary: [Fallback option](pytorch/test-infra@751efc1) is added and merge for Nova @ main branch. We can safely revert D55947486 to use main branch. D55947486 was to mainly unblock nightly releases and to be used for OSS release cycle. Note that the change of [switching to Nova release branch](pytorch#2489 (comment)) had already been cherrypicked into release branch (v0.7.0-release) Differential Revision: D55993279
facebook-github-bot
pushed a commit
that referenced
this pull request
Apr 11, 2024
Summary: Pull Request resolved: #2493 [Fallback option](pytorch/test-infra@751efc1) is added and merge for Nova @ main branch. We can safely revert D55947486 to use main branch. D55947486 was to mainly unblock nightly releases and to be used for OSS release cycle. Note that the change of [switching to Nova release branch](#2489 (comment)) had already been cherrypicked into release branch (v0.7.0-release) Reviewed By: q10 Differential Revision: D55993279 fbshipit-source-id: 56161076e6d3f52dccb0be3f4cddd0efea0f6668
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Differential Revision: D55947486