Fix AMD FP8 Test and use native rowwise quantization in benchmark #2849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for pytorch-fbgemm-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
This pull request was exported from Phabricator. Differential Revision: D59771162 |
|
This pull request was exported from Phabricator. Differential Revision: D59771162 |
jwfromm
added a commit
to jwfromm/FBGEMM
that referenced
this pull request
Jul 16, 2024
…torch#2849) Summary: Pull Request resolved: pytorch#2849 Fix a minor test issue where triton blockwise quantization was running on AMD despite not being supported. I also switch rowwise quantization in our fp8 benchmarks to the native hip implementation. Reviewed By: jianyuh Differential Revision: D59771162
jwfromm
force-pushed
the
export-D59771162
branch
from
37ba9ec to
dd051db
Compare
|
This pull request was exported from Phabricator. Differential Revision: D59771162 |
jwfromm
added a commit
to jwfromm/FBGEMM
that referenced
this pull request
Jul 16, 2024
…torch#2849) Summary: Pull Request resolved: pytorch#2849 Fix a minor test issue where triton blockwise quantization was running on AMD despite not being supported. I also switch rowwise quantization in our fp8 benchmarks to the native hip implementation. Reviewed By: jianyuh Differential Revision: D59771162
jwfromm
force-pushed
the
export-D59771162
branch
from
dd051db to
2cbdfbe
Compare
…torch#2849) Summary: Pull Request resolved: pytorch#2849 Fix a minor test issue where triton blockwise quantization was running on AMD despite not being supported. I also switch rowwise quantization in our fp8 benchmarks to the native hip implementation. Reviewed By: jianyuh Differential Revision: D59771162
|
This pull request was exported from Phabricator. Differential Revision: D59771162 |
jwfromm
force-pushed
the
export-D59771162
branch
from
2cbdfbe to
75ff00a
Compare
|
This pull request has been merged in 57a5969. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Fix a minor test issue where triton blockwise quantization was running on AMD despite not being supported.
I also switch rowwise quantization in our fp8 benchmarks to the native hip implementation.
Reviewed By: jianyuh
Differential Revision: D59771162