Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add masked_index_select and refactor masked_index_put #2910

Closed
wants to merge 3 commits into from

Conversation

sryap
Copy link
Contributor

@sryap sryap commented Jul 29, 2024

Summary:
This diff adds torch.ops.fbgemm.masked_index_select (will be used in
subsequent diffs) and refactors torch.ops.fbgemm.masked_index_put.

  • Add unit tests
  • Add docstrings
  • Add contiguous tensor checks

Differential Revision: D60362812

Copy link

netlify bot commented Jul 29, 2024

Deploy Preview for pytorch-fbgemm-docs ready!

Name Link
🔨 Latest commit 348425d
🔍 Latest deploy log https://app.netlify.com/sites/pytorch-fbgemm-docs/deploys/66a825095d7ddf0008584413
😎 Deploy Preview https://deploy-preview-2910--pytorch-fbgemm-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D60362812

sarunya added 2 commits July 29, 2024 14:22
Differential Revision: D60348604
Differential Revision: D60356701
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D60362812

sryap added a commit to sryap/FBGEMM that referenced this pull request Jul 29, 2024
Summary:
Pull Request resolved: pytorch#2910

This diff adds `torch.ops.fbgemm.masked_index_select` (will be used in
subsequent diffs) and refactors `torch.ops.fbgemm.masked_index_put`.

- Add unit tests
- Add docstrings
- Add contiguous tensor checks

Differential Revision: D60362812
@sryap sryap force-pushed the export-D60362812 branch from b9e8bb2 to c4ab337 Compare July 29, 2024 21:31
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D60362812

sryap added a commit to sryap/FBGEMM that referenced this pull request Jul 29, 2024
Summary:
Pull Request resolved: pytorch#2910

This diff adds `torch.ops.fbgemm.masked_index_select` (will be used in
subsequent diffs) and refactors `torch.ops.fbgemm.masked_index_put`.

- Add unit tests
- Add docstrings
- Add contiguous tensor checks

Differential Revision: D60362812
@sryap sryap force-pushed the export-D60362812 branch from c4ab337 to b905f14 Compare July 29, 2024 21:36
Summary:
Pull Request resolved: pytorch#2910

This diff adds `torch.ops.fbgemm.masked_index_select` (will be used in
subsequent diffs) and refactors `torch.ops.fbgemm.masked_index_put`.

- Add unit tests
- Add docstrings
- Add contiguous tensor checks

Reviewed By: q10

Differential Revision: D60362812
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D60362812

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 1fa5a68.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants