Do not import from pyre_extensions #2937
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: pyre_extensions not availabe in trec OSS. breaks torchrec build tests: https://github.com/pytorch/torchrec/actions/runs/10222011214/job/28285796153 pyre_extensions is also not safe to use in code that will be torch.packaged, as it requires sys for version checks Reviewed By: duduyi2013 Differential Revision: D60792133
✅ Deploy Preview for pytorch-fbgemm-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
This pull request was exported from Phabricator. Differential Revision: D60792133 |
|
This pull request has been merged in 7e17a6e. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
pyre_extensions not availabe in trec OSS.
breaks torchrec build tests: https://github.com/pytorch/torchrec/actions/runs/10222011214/job/28285796153
pyre_extensions is also not safe to use in code that will be torch.packaged, as it requires sys for version checks
Reviewed By: duduyi2013
Differential Revision: D60792133