include fb only ops in private fbgemm build #2972
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Check internal fbcode import + test X-link: facebookresearch/FBGEMM#66 Differential Revision: D61082733 Pulled By: jianyuh
✅ Deploy Preview for pytorch-fbgemm-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
This pull request was exported from Phabricator. Differential Revision: D61100617 |
|
This pull request was exported from Phabricator. Differential Revision: D61100617 |
jianyuh
added a commit
to jianyuh/FBGEMM
that referenced
this pull request
Aug 12, 2024
Summary: Pull Request resolved: pytorch#2972 X-link: facebookresearch/FBGEMM#69 On fb only source files, we have CMake files based on USE_FB_ONLY compiler flag: ``` # Set the source file for FB only CPP if(USE_FB_ONLY) file(GLOB fb_only_ops_sources fb/src/*/*.cu fb/src/*/*.cpp) list(APPEND experimental_gen_ai_cpp_source_files ${fb_only_ops_sources}) endif() ``` Reviewed By: GD06 Differential Revision: D61100617
jianyuh
force-pushed
the
export-D61100617
branch
from
1c5965d to
7d7f829
Compare
|
This pull request was exported from Phabricator. Differential Revision: D61100617 |
jianyuh
added a commit
to jianyuh/FBGEMM
that referenced
this pull request
Aug 12, 2024
Summary: Pull Request resolved: pytorch#2972 X-link: facebookresearch/FBGEMM#69 On fb only source files, we have CMake files based on USE_FB_ONLY compiler flag: ``` # Set the source file for FB only CPP if(USE_FB_ONLY) file(GLOB fb_only_ops_sources fb/src/*/*.cu fb/src/*/*.cpp) list(APPEND experimental_gen_ai_cpp_source_files ${fb_only_ops_sources}) endif() ``` Reviewed By: GD06 Differential Revision: D61100617
jianyuh
force-pushed
the
export-D61100617
branch
from
7d7f829 to
f7c562b
Compare
|
This pull request was exported from Phabricator. Differential Revision: D61100617 |
jianyuh
added a commit
to jianyuh/FBGEMM
that referenced
this pull request
Aug 12, 2024
Summary: Pull Request resolved: pytorch#2972 X-link: facebookresearch/FBGEMM#69 On fb only source files, we have CMake files based on USE_FB_ONLY compiler flag: ``` # Set the source file for FB only CPP if(USE_FB_ONLY) file(GLOB fb_only_ops_sources fb/src/*/*.cu fb/src/*/*.cpp) list(APPEND experimental_gen_ai_cpp_source_files ${fb_only_ops_sources}) endif() ``` Reviewed By: GD06 Differential Revision: D61100617
jianyuh
force-pushed
the
export-D61100617
branch
from
f7c562b to
4e1853d
Compare
Summary: Pull Request resolved: pytorch#2972 X-link: facebookresearch/FBGEMM#69 On fb only source files, we have CMake files based on USE_FB_ONLY compiler flag: ``` # Set the source file for FB only CPP if(USE_FB_ONLY) file(GLOB fb_only_ops_sources fb/src/*/*.cu fb/src/*/*.cpp) list(APPEND experimental_gen_ai_cpp_source_files ${fb_only_ops_sources}) endif() ``` Reviewed By: GD06 Differential Revision: D61100617
|
This pull request was exported from Phabricator. Differential Revision: D61100617 |
jianyuh
force-pushed
the
export-D61100617
branch
from
4e1853d to
bdf8055
Compare
|
This pull request has been merged in 6a3ff16. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
On fb only source files, we have CMake files based on USE_FB_ONLY compiler flag:
Reviewed By: GD06
Differential Revision: D61100617