MX4 Row-Based Padding #3010
Closed
MX4 Row-Based Padding #3010
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for pytorch-fbgemm-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
This pull request was exported from Phabricator. Differential Revision: D61447274 |
|
This pull request was exported from Phabricator. Differential Revision: D61447274 |
jwfromm
force-pushed
the
export-D61447274
branch
from
69ce137 to
63b1580
Compare
jwfromm
added a commit
to jwfromm/FBGEMM
that referenced
this pull request
Aug 18, 2024
Summary: Pull Request resolved: pytorch#3010 X-link: facebookresearch/FBGEMM#105 Refactor MX4 quantization to support per row padding as efficiently as possible. We do this in a cool way where we now support loading 2D blocks to make sure each thread has enough to work on. Using this approach, we should be able to apply padding to each row for effectively no cost. Differential Revision: D61447274
Summary: Pull Request resolved: pytorch#3010 X-link: facebookresearch/FBGEMM#105 Refactor MX4 quantization to support per row padding as efficiently as possible. We do this in a cool way where we now support loading 2D blocks to make sure each thread has enough to work on. Using this approach, we should be able to apply padding to each row for effectively no cost. Differential Revision: D61447274
|
This pull request was exported from Phabricator. Differential Revision: D61447274 |
jwfromm
force-pushed
the
export-D61447274
branch
from
63b1580 to
b83cab0
Compare
|
This pull request has been merged in a973b75. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Refactor MX4 quantization to support per row padding as efficiently as possible. We do this in a cool way where we now support loading 2D blocks to make sure each thread has enough to work on. Using this approach, we should be able to apply padding to each row for effectively no cost.
Differential Revision: D61447274