-
Notifications
You must be signed in to change notification settings - Fork 521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Follow up on removing fb namespace for uvm API #945
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pull request was exported from Phabricator. Differential Revision: D34382559 |
Summary: Pull Request resolved: pytorch#945 As title. This Diff will be landed after the previous Diff is populated into production. Please feel free to accept and I will monitor the production package and land it later to avoid BC breaking issue. Reviewed By: jspark1105, jasonjk-park Differential Revision: D34382559 fbshipit-source-id: 1ce27c2e4d09a9e320015ef3a449e9246852f65e
jianyuh
force-pushed
the
export-D34382559
branch
from
October 23, 2022 00:36
a222221
to
2479710
Compare
This pull request was exported from Phabricator. Differential Revision: D34382559 |
✅ Deploy Preview for pytorch-fbgemm-docs canceled.
|
airidas-meta
added a commit
to airidas-meta/FBGEMM
that referenced
this pull request
Nov 1, 2022
Summary: Pull Request resolved: pytorch#1427 Pull Request resolved: pytorch#945 As title. This Diff will be landed after the previous Diff is populated into production. Please feel free to accept and I will monitor the production package and land it later to avoid BC breaking issue. Differential Revision: D40620055 fbshipit-source-id: 607b10b90827c9d31f93c4035d392de09a90653c
airidas-meta
added a commit
to airidas-meta/FBGEMM
that referenced
this pull request
Nov 1, 2022
Summary: Pull Request resolved: pytorch#1427 Pull Request resolved: pytorch#945 As title. This Diff will be landed after the previous Diff is populated into production. Please feel free to accept and I will monitor the production package and land it later to avoid BC breaking issue. Differential Revision: D40620055 fbshipit-source-id: e5706bf11fb3056a988e08ccbb740947bfc9dc9b
airidas-meta
added a commit
to airidas-meta/FBGEMM
that referenced
this pull request
Nov 1, 2022
Summary: Pull Request resolved: pytorch#1427 Pull Request resolved: pytorch#945 As title. This Diff will be landed after the previous Diff is populated into production. Please feel free to accept and I will monitor the production package and land it later to avoid BC breaking issue. Differential Revision: D40620055 fbshipit-source-id: 367ade5abb86a5e90ccc7f2c6541d008fb3f42c5
airidas-meta
added a commit
to airidas-meta/FBGEMM
that referenced
this pull request
Nov 1, 2022
Summary: Pull Request resolved: pytorch#1427 Pull Request resolved: pytorch#945 As title. This Diff will be landed after the previous Diff is populated into production. Please feel free to accept and I will monitor the production package and land it later to avoid BC breaking issue. Differential Revision: D40620055 fbshipit-source-id: cb919ab86846073e75fdc257c173f15db16821ba
facebook-github-bot
pushed a commit
that referenced
this pull request
Nov 2, 2022
Summary: Pull Request resolved: #1427 Pull Request resolved: #945 As title. This Diff will be landed after the previous Diff is populated into production. Please feel free to accept and I will monitor the production package and land it later to avoid BC breaking issue. Fixed some of the lint issues, and ignored some others. Reviewed By: jianyuh Differential Revision: D40620055 fbshipit-source-id: 1f00037c8f64a2b873f87f90edf433d8a029da5b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: As title. This Diff will be landed after the previous Diff is populated into production. Please feel free to accept and I will monitor the production package and land it later to avoid BC breaking issue.
Differential Revision: D34382559