feat: Add support for dynamic zeros_like and ones_like #1847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
component: conversion
narendasan
reviewed
May 22, 2023
core/conversion/evaluators/aten.cpp
Outdated
| @@ -124,6 +125,77 @@ DEFINE_TWO_INPUT_SIMPLE_EVALUATOR( | |||
| int64_t, | |||
| {"aten::__round_to_zero_floordiv(int a, int b) -> (int)"}); | |||
|
|
|||
| std::pair<std::vector<int64_t>, torch::TensorOptions> newTensorImplementation(const torch::jit::Node* n, kwargs& args) { | |||
There was a problem hiding this comment.
I think we should probably put these helpers in the utils file.
narendasan
reviewed
May 22, 2023
core/conversion/evaluators/aten.cpp
Outdated
| auto tensor = tensor_var.unwrapToTensor(); | ||
| tensor_dims = tensor.sizes().vec(); | ||
| } | ||
| if (ctx->input_is_dynamic) { |
There was a problem hiding this comment.
This condition is too broad and results in additional bugs being injected. In the other dynamic shape PRs we also use the opt in shape tensor setting to limit the scope which should be good enough for now but really this should only run when the input is itself a ShapeTensor.
narendasan
approved these changes
May 30, 2023
|
@narendasan It looks like the CI issue is not specific to this PR. Any action needed on my side? |
|
You might need to rebase, the nightly version might be too old for this base branch |
mfeliz-cruise
force-pushed
the
michael.feliz/dynamic_zeros_like
branch
from
c837942
to
ae4244f
Compare
github-actions
bot
added
the
component: converters
mfeliz-cruise
force-pushed
the
michael.feliz/dynamic_zeros_like
branch
from
ae4244f
to
864c001
Compare
|
@peri044 Should be ready to go. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds support for a variety of tensor creation ops including dynamic shape support for ones_like and zeros_like.
Ops supported:
aten::new_zeros
aten::new_ones
aten::zeros_like
aten::ones_like
aten::fill_
Fixes # (issue)
Type of change
Please delete options that are not relevant and/or add your own.
Checklist: