Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Improve Docker build robustness, add validation #1873

Merged
merged 1 commit into from
May 4, 2023
Merged

fix: Improve Docker build robustness, add validation #1873

merged 1 commit into from
May 4, 2023

Conversation

gs-olive
Copy link
Collaborator

@gs-olive gs-olive commented May 1, 2023

Description

  • Add improved Docker build robustness by automatically correcting the attached cuda directory
  • Allow specification of TensorRT and cuDNN versions as a.b (requiring only two values instead of three)
  • Validate inputs and perform symlinks more cleanly
  • Improve wildcard-matching system for apt versions on key nvinfer libraries
  • Update README documentation

Type of change

  • Improve Docker build system
  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • [ x ] My code follows the style guidelines of this project (You can use the linters)
  • [ x ] I have performed a self-review of my own code
  • [ x ] I have commented my code, particularly in hard-to-understand areas and hacks
  • [ x ] I have made corresponding changes to the documentation
  • [ x ] I have added tests to verify my fix or my feature
  • [ x ] New and existing unit tests pass locally with my changes
  • [ x ] I have added the relevant labels to my PR in so that relevant reviewers are notified

@gs-olive
fix: Improve Docker build robustness, add validation
659c901 
- Add improved Docker build robustness by automatically correcting the
attached `cuda` directory
- Allow specification of TensorRT and cuDNN versions as a.b (requiring
only two values instead of three)
- Validate inputs and perform symlinks more cleanly
- Improve wildcard-matching system for apt versions on key nvinfer
libraries
- Update README documentation
@gs-olive gs-olive requested a review from narendasan May 1, 2023 17:39
@gs-olive gs-olive self-assigned this May 1, 2023
narendasan
narendasan approved these changes May 3, 2023
View reviewed changes
Copy link
Collaborator

@narendasan narendasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gs-olive gs-olive merged commit 25db257 into pytorch:main May 4, 2023
@gs-olive gs-olive deleted the docker_robustness_improvements branch May 4, 2023 00:36
gs-olive added a commit that referenced this pull request May 8, 2023
@gs-olive
fix: Improve Docker build robustness, add validation (#1873)
3575478
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@narendasan narendasan narendasan approved these changes

Assignees

@gs-olive gs-olive

Labels
cla signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gs-olive @narendasan @facebook-github-bot