Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DLFW changes #1878

Merged
merged 2 commits into from
May 30, 2023
Merged

DLFW changes #1878

merged 2 commits into from
May 30, 2023

Conversation

apbose
Copy link
Collaborator

@apbose apbose commented May 1, 2023

The following files are modified-

  1. docker/WORKSPACE.ngc changing the python lib files to python 3.10. Hardcoded at present
  2. noxfile.py changing the PYT_PATH to python3.10

github-actions[bot]
github-actions bot approved these changes May 1, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to C++ style guidelines

github-actions[bot]
github-actions bot approved these changes May 1, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to Python style guidelines

@apbose apbose requested review from narendasan and peri044 May 1, 2023 22:39
github-actions[bot]
github-actions bot approved these changes May 1, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to C++ style guidelines

github-actions[bot]
github-actions bot approved these changes May 1, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to Python style guidelines

github-actions[bot]
github-actions bot approved these changes May 1, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to C++ style guidelines

github-actions[bot]
github-actions bot approved these changes May 1, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to Python style guidelines

@apbose
Copy link
Collaborator Author

apbose commented May 1, 2023

Any thoughts on removing the hardcoded paths? Should be do something like sym links as we do in torch TRT in DLFW?

narendasan
narendasan approved these changes May 4, 2023
View reviewed changes
Copy link
Collaborator

@narendasan narendasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@narendasan narendasan merged commit 838d26b into main May 30, 2023
narendasan pushed a commit that referenced this pull request May 30, 2023
@apbose @narendasan
DLFW changes (#1878)
a85eb75
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] approved these changes

@narendasan narendasan narendasan approved these changes

@peri044 peri044 Awaiting requested review from peri044

Assignees
No one assigned
Labels
cla signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@apbose @narendasan @facebook-github-bot